[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#719171: marked as done (ocaml-mode: caml-set-compile-command quote filename)

Your message dated Mon, 26 Dec 2016 11:01:06 +0100
with message-id <65135dab-0065-00f3-370c-bce8e774d157@dogguy.org>
and subject line Re: Bug#719171: ocaml-mode: caml-set-compile-command quote filename
has caused the Debian Bug report #719171,
regarding ocaml-mode: caml-set-compile-command quote filename
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
719171: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719171
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: ocaml-mode
Version: 3.12.1-4
Severity: minor
File: /usr/share/emacs/site-lisp/ocaml-mode/caml.el

caml-set-compile-command could helpfully quote the buffer filename in
the compile-command it builds

    (setq compile-command (concat command " "
                                  (shell-quote-argument filename)))))

This lets it work on filenames with spaces, and guards against executing
arbitrary shell code if the filename has a ";" or similar special
character.


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-486
Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages ocaml-mode depends on:
ii  emacs21 [emacsen]        21.4a+1-5.7
ii  emacs22-gtk [emacsen]    22.3+1-1.2
ii  emacs23-lucid [emacsen]  23.4+1-4
ic  emacs24 [emacsen]        24.3+1-1
ii  emacs24-lucid [emacsen]  24.3+1-1
ii  xemacs21-mule [emacsen]  21.4.22-4

ocaml-mode recommends no packages.

Versions of packages ocaml-mode suggests:
pn  ocaml  <none>

-- no debconf information

--- End Message ---
--- Begin Message --- 
Version: 4.01.0-1

On 09/08/2013 02:53, Kevin Ryde wrote:
> Package: ocaml-mode
> Version: 3.12.1-4
> Severity: minor
> File: /usr/share/emacs/site-lisp/ocaml-mode/caml.el
> 
> caml-set-compile-command could helpfully quote the buffer filename in
> the compile-command it builds
> 
>     (setq compile-command (concat command " "
>                                   (shell-quote-argument filename)))))
> 
> This lets it work on filenames with spaces, and guards against executing
> arbitrary shell code if the filename has a ";" or similar special
> character.
> 

The above code was disabled in 4.01.0-1. I have to admit that I am not sure
if this bug should be closed or not, since the code is still in the file but
not enabled (due to [1]).

[1] https://caml.inria.fr/mantis/print_bug_page.php?bug_id=4469

Feel free to re-open the bugreport is you feel the code should be fixed or
completely gone in order to close this bugreport.

Regards,

-- 
Mehdi

--- End Message ---
Reply to: