On Wed, Oct 01, 2008 at 10:13:06PM +0200, Loïc Minier wrote:
> Package: facile
> Version: 1.1-6.1
> Severity: normal
> Tags: patch
>
> Hi there,
>
> I had a look at the facile source package today, and noticed some odd
> things in the packaging; I've cleaned it up a little in the attached
> debdiff. (I'm filing this at normal severity because of the copyright
> issues.)
Thanks for this effort.
I do have a minimal objection though, given that facile is already
using CDBS, why is it _not_ using the ocaml.mk CDBS class provided by
dh-ocaml (new name, it was formerly provided by ocaml itself)?
At least some of the stuff which is being done in debian/rules is
already done in that class, and having that logic in a single
package/place is of course better for the sake of flexibility ...
Cheers.
--
Stefano Zacchiroli -*- PhD in Computer Science \ PostDoc @ Univ. Paris 7
zack@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/
I'm still an SGML person,this newfangled /\ All one has to do is hit the
XML stuff is so ... simplistic -- Manoj \/ right keys at the right time
Attachment:
signature.asc
Description: Digital signature