[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ocaml-sha1 library



On Wed, Jul 19, 2006 at 04:35:20PM -0400, Eric Cooper wrote:
> I'd appreciate a sponsored upload; thanks.

ATM it is not lintian clean:

  lintian /local/zack/pkg-ocaml-maint/trunk/packages/ocaml-sha1/build-area/ocaml-sha1_0.4-1_i386.changes
  E: ocaml-sha1 source: package-lacks-versioned-build-depends-on-debhelper 5

Please fix it.

I also see your ml.dpatch rename upstream types in the Sha1 module. Why
you do that? In general it seems to be a bad idea diverging from
upstream naming convention, especially when touching an interface since
it will break .cmi compatibility. Are you in touch with upstream or
something else which justifies such a change?

Cheers.

-- 
Stefano Zacchiroli -*- Computer Science PhD student @ Uny Bologna, Italy
zack@{cs.unibo.it,debian.org,bononia.it} -%- http://www.bononia.it/zack/
If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. -!-

Attachment: signature.asc
Description: Digital signature


Reply to: