[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1106283: libid3tag0: Debian Sid patch series erroneously includes 10_utf16.patch



Package: libid3tag0
Version: 0.16.3-1
Severity: minor
Tags: patch
X-Debbugs-Cc: connect@brian-arnold.dev

Dear Maintainer,

The patch included in '10_utf16.patch' was actually already included in
upstream, checking utf16.c shows that the section of code added by the
patch is already present.

In the Debian git repo, the patch was integrated in commit d68ccb0 when
upstream changes were included.

In upstream, it was included in commit 2a0f4df.

(if I'm reading the git log correctly, I *think* it should have been
removed along with all other patches in commit bf7fe8d ?)

I've attached a patch that I *think* should fix the erroneous patch.

Note: I don't believe this incorrect patch actually breaks anything, as
the previous if block sets the pointer to end+1 anyway, so the added if
block should never be executed.

-- System Information:
Debian Release: 13.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.12.29-amd64 (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libid3tag0 depends on:
ii  libc6   2.41-8
ii  zlib1g  1:1.3.dfsg+really1.3.1-1+b1

libid3tag0 recommends no packages.

libid3tag0 suggests no packages.

-- no debconf information

Attachment: 0001-Remove-the-10_utf16.patch-it-was-already-applied-ups.patch
Description: application/mbox


Reply to: