Bug#1110378: RFS: kafel/20231004 [ITP] -- seccomp-bpf language parser for nsjail

[Tobias Frost <tobi@debian.org>]

Control: tags -1 moreinfo

Hi Stephen,

this is an incomplete review, especially I did not do any copyright
review, but the package needs some work. Remove the moreinfo tag when
ready.

d/README.md:
 - Debian-Policy-wise this resembles something like a README.source (see
   policy 4.14), probably that would be a better name.
   The introductional section (what is kafel) is redudant to d/control.
   Some of the hints should be encoded in d/gbp.conf, so that gbp does
   not need all those flags.
   You should also *always* build in a clean environment, for example
   using sbuild or pbuilder.
 
d/control:
 - VCS-*-fields point to where the *Debian packaging* is happening, not
   upstream.
 - The description of the binary packages needs to be reworked, it
   should explain what kafel is. See Debian Policy §3.4 what it expected
   for a good Description:
 - Rules-Requires-Root=no is the default and can be removed.

d/LICENSE does not need to be there, remove it.

d/*install hardcodes multiarch paths. That won't work, instead of the
architecture triplet, use ${DEB_HOST_MULTIARCH} - see dh_install(1)

please add a upstream/metadata file. 

Cheers,
--
tobi

On Sun, Aug 03, 2025 at 10:13:18PM -0700, Stephen Crosby wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "kafel":
> 
>  * Package name     : kafel
>    Version          : 0~20231004-1
>    Upstream contact : https://github.com/google/kafel/issues
>  * URL              : https://github.com/google/kafel
>  * License          : Apache-2.0
>  * Vcs              : https://github.com/google/kafel
>    Section          : libs
> 
> The source builds the following binary packages:
> 
>   libkafel1 - Shared library for kafel policy parser
>   libkafel-dev - Development files for the kafel policy parser
> 
> To access further information about this package, please visit the
> following URL:
> 
>   https://mentors.debian.net/package/kafel/
> 
> Alternatively, you can download the package with 'dget' using this command:
> 
>   dget -x
> https://mentors.debian.net/debian/pool/main/k/kafel/kafel_0~20231004-1.dsc
> 
> Changes for the initial release:
> 
>  kafel (0~20231004-1) unstable; urgency=medium
>  .
>    * Initial release.
> 
> Regards,
> -- 
>   Stephen Crosby