Bug#1111680: RFS: ascii-draw/1.1.0-1 [ITP] -- Create beautiful diagrams and artwork using only ASCII characters
Hi Seyed,
thanks for the update.
regarding the dep3-headers: Please read https://dep-team.pages.debian.net/deps/dep3/
for the format. e.g the fix-font patch should be
Description: <summary description about the bug>
<longer description; whats wrong etc, how it manifests, how this patch
fixes it.>
Author: <your name and email>
Bug: https://github.com/Nokse22/ascii-draw/issues/66
Forwarded: <whether you have forwarded the patch to upstream, ideally with reference where to find the patch/merge request upstream>
(As said, the tool quilt can help you with filling the template)
A well meant hint: Always try to upstream your patches, except the
patches are clearly Debian-specific.
d/copyright: thanks for the update, but there is still a problem:
your d/copyright says for .github/code-of-conduct.md:
Files: .github/code-of-conduct.md
Copyright:
2023-2025 Nokse <nokse@posteo.com>
License: CC-BY-SA-3.0
But the file says:
SPDX-FileCopyrightText: 2021 GNOME Foundation
regarding the man page: With Debian Policy lingo, this is a "should"
policy, which means in Debian Policy language:
The terms should and should not, and the adjective recommended, denote
best practices. Non-conformance with these guidelines will generally
be considered a bug, but will not necessarily render a package
unsuitable for distribution. These statements correspond to bug
severities of important, normal, and minor. They are collectively
called Policy recommendations.
So I guess it is ok to start without one.
As an option: if ascii-draw --help works, look into help2man to
auto-generate the manpage.
Otherwise, package looks good - so after fixing above, I think its ready
for upload.
On Fri, Oct 17, 2025 at 10:17:33PM +0000, Seyed Mohamad Amin Modaresi wrote:
> Control: tags -1 moreinfo
hint: to remove tags, you need to
Control: tags -1 -moreinfo
(mind the "-" before moreinfo)
> Thank you very much tobi for the reviwe
>
>
> I fixed the issues (Except manual page, is it needed?)
>
> https://salsa.debian.org/amin_modaresi/ascii-draw/-/commits/master?ref_type=heads
>
> But I have a problem, The test part of package build tests some links in the metainfo files.
Can you explain what you mean? (It seems that the test suite executes
just fine)
> My internet is not good so I can't build the package myself, so I uploaded salsa build files.
understood. long term you might want to fix this; possibly setting up a
local apt-cacher instance might help you to reduce the amount of
packages you need to download for a build; also, look into building with
sbuild or pbuilder.
--
tobi
Reply to: