Bug#1111680: RFS: ascii-draw/1.1.0-1 [ITP] -- Create beautiful diagrams and artwork using only ASCII characters

[Tobias Frost <tobi@debian.org>]

Control: tags -1 moreinfo

Hi,

here's a short review:

d/copyright: 
 - undocumented files, e.g .github/code-of-conduct.md is CC-BY-SA-3.0.
 - copyright years are not matching the code, I see e.g 
   "Copyright 2023-2025 Nokse" in a file.


d/patches:
 - the patches are missing dep3 headers, e.g description what they are
   fixing. Do they need to be upstreamed? Are there upstream issues
   filed?
   hint: quilt header -e --dep3 gives you a template.

d/docs:
 - README.md does only contain information not relevant for Debian,
   like how to install. Don't install that file.

d/rules:
 - don't skip the tests.

lintian:
W: ascii-draw: appstream-metadata-validation-failed Problems reported by "appstreamcli validate-tree".
W: ascii-draw: no-manual-page [usr/bin/ascii-draw]
I: ascii-draw source: older-debian-watch-file-standard 4 [debian/watch]
I: ascii-draw source: quilt-patch-missing-description [debian/patches/fix_ascii_draw_permission.patch]
I: ascii-draw source: quilt-patch-missing-description [debian/patches/fix_font.patch]


--  
tobi