Control: tags -1 moreinfo
On Sun, 20 Jul 2025 11:37:12 +0000
Aryan Karamtoth <aryankmmiv@outlook.com> wrote:
> I am looking for a sponsor for my package python-itertree:
hi Aryan,
thanks for addressing the licensing issue with upstream. I took a
look at your latest upload on mentors, and several issues came up.
For starters, a couple of observations about the salsa repo:
* d/salsa-ci.yml exists but the CI isn't actually enabled in the
repository settings. Please update the repository settings to
enable the CI.
* the pristine-tar branch is missing. Please follow the team's
packaging standards as documented in its policy, and push the
missing branch (try 'gbp push').
Then for the packaging itself:
* watch: not working, payload url commented out? Basics such as
updating to a new version via 'gbp import-orig' cannot function
this way, nor can tracking new upstream releases on the package
tracker.
* copyright: upstream's LICENSE file identifies the copyright holder
as "B.R." but that person is listed by another name in the 'Files
*' paragraph; years similarly diverge (2025 vs. 2023-2025).
* copyright: the license paragraph should only contain the license
terms, not repeat upstream copyright statements, license name, etc;
separate fields exist for all that.
* control: unused build-deps on python3-pluggy, python3-typeguard,
python3-wheel?
* control: extended description could be way more informative. What
makes this module special, why would one want to use it? Upstream
docs often provide good material to base the description on.
* control: why the hardcoded dependency on python3-all for the binary
package? It's rather unlikely a simple module would require *all*
currently supported Python versions installed at the same time.
* control: missing dependency on the binary pkg for orjson (see
upstream installation docs for why this module wants it):
src/itertree/itree_serializer/itree_json_serialize.py:39: import orjson as JSON
src/itertree/itree_serializer/itree_json_converter.py:39: import orjson as JSON
* autopkgtest: consider setting 'Testsuite: autopkgtest-pkg-pybuild'
in d/control to run the upstream testsuite in an autopkgtest
context.
* rules: multiple tests are ignored, why? Most of the disabled tests
seem to complete just fine.
+ tests/test_itertree_mathsets.py appears to contain simply typos
(missing whitespace in the assert?):
tests/test_itertree_mathsets.py:439
/build/python-itertree-1.2.0/.pybuild/cpython3_3.13_itertree/build/tests/test_itertree_mathsets.py:439: SyntaxWarning: invalid decimal literal
assert -1.1111not in i
tests/test_itertree_mathsets.py:862
/build/python-itertree-1.2.0/.pybuild/cpython3_3.13_itertree/build/tests/test_itertree_mathsets.py:862: SyntaxWarning: invalid decimal literal
assert -1.1111not in i
+ tests/test_itertree_serialize.py seems to be missing the
tests/test_converter directory, which is absent from the pypi
tarball but does exist on github.
Please verify both issues, and report them upstream. Consider
switching the watch file to github for the time being so all
test files are available.
* examples: installed into the python path as part of the module,
rather than as documentation. Are you sure about that? The usual
location in Debian for examples is /usr/share/doc/<pkg>/examples.
Please remove the moreinfo tag (and CC me) once you have an updated
package ready.
Attachment:
pgpDAv6KNtwIv.pgp
Description: OpenPGP digital signature