Bug#991118: RFS: openarc/1.0.0~beta3+dfsg-1~exp1
Hello Daniel,
thank you very much for the review.
For all of your items I will comment ‘I did it just like in opendkim and
opendmarc’, but let’s go through them.
> * debian/copyright:
> The upstream contact should not be a name only, but a means of
> contact, such as an email address.
Right, I found an email address: info@trusteddomain.org
> * debian/copyright:
> the formatting of the file is a bit off; the "m4/ac_pthread.m4"-
> stanza and the GPL license block are "clumped together".
>
> the "Files:" blocks and the "License:" blocks are separate things,
> see e.g.
> http://metadata.ftp-master.debian.org/changelogs/main/l/lzip/unstable_copyright
> as an example where (hopefully) it's easy to
> see what I mean.
>
> * debian/copyright:
> the m4 macro doesn't need to be listed (see the exception), but it
> also doesn't harm.
According to the documentation, this is a valid way of specifying the
licence. ‘License:’ can either be one line, then it contains
identifier(s) pointing to text elsewhere. Or it can be several lines,
then it must include the whole licence text inline. That’s what I did
for this particular m4 file.
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-field
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#examples
> * debian/copyright:
> what about the license for the debian packaging?
Right, I think I will just use GPL-3+ for debian/*.
> * debian/*.postrm:
> why removing the systemd service file on purge? if it's included in
> the package (rather than generated at install time, which would be
> "unusual" anyway), then, it will automatically be purged by dpkg.
Yes, we can get rid of the postrm script entirely.
> * did you consider using 'wrap-and-sort -bast'?
I hadn’t heard of this before. It doesn’t really seem important to me to
be honest, but I can apply it if that’s preferred.
So thanks again. I will update the package and reupload soon.
Ciao,
David
Reply to: