[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991118: RFS: openarc/1.0.0~beta3+dfsg-1~exp1



Hi David,

I had a look at your openarc package. All in all it looks mostly good,
there are a few minor things:

  * debian/copyright:
    The upstream contact should not be a name only, but a means of
    contact, such as an email address.

  * debian/copyright:
    the formatting of the file is a bit off; the "m4/ac_pthread.m4"-
    stanza and the GPL license block are "clumped together".

    the "Files:" blocks and the "License:" blocks are separate things,
    see e.g.
http://metadata.ftp-master.debian.org/changelogs/main/l/lzip/unstable_copyright
as an example where (hopefully) it's easy to
    see what I mean.

  * debian/copyright:
    the m4 macro doesn't need to be listed (see the exception), but it
    also doesn't harm.

  * debian/copyright:
    what about the license for the debian packaging?

  * debian/*.postrm:
    why removing the systemd service file on purge? if it's included in
    the package (rather than generated at install time, which would be
    "unusual" anyway), then, it will automatically be purged by dpkg.

  * did you consider using 'wrap-and-sort -bast'?

Regards,
Daniel


Reply to: