[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#956907: RFS: ace/6.5.8+dfsg-1 [RC] -- makefile, project, and workspace creator



Control: tags -1 moreinfo

Hi Sudip,

here's a review, no specific order:

- it seems that there is an ABI bump in the libraries (as packages get renamed and so on…).
  Please target "experimental" for this upload, as this will trigger an transistion [1] and also
  needs to clear "NEW".

- d/copyright needs some years updated. Bonus points for converting it to dep5 (its almost already dep5, so likely quickly converted)

[1] https://wiki.debian.org/Teams/ReleaseTeam/Transitions

- you should probably close #878198; I see the change but it is not mentioned in the changelog.

- you should probably also close #954252 (at least the bts says it is fixed by the new upstream version)

Regarding the symbols: Be aware that symbols are tricky for C++ code,
especially for different architectures… Lets see and wait how it turns out, but
do not hesitate to undo that if you feel it becomes a burden. 

-- 
tobi


Reply to: