Bug#956601: RFS: libcyaml/1.0.2-1 [ITP] -- library to read and write YAML documents (shared library)

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

Hi Andrej,

Thanks for taking a look.

On Mon, Apr 13, 2020 at 04:57:53PM +0200, Andrej Shadura wrote:
> Hi,
> 
> On Mon, 13 Apr 2020 at 15:41, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > Package: sponsorship-requests
> > Severity: wishlist
> >
<snip>
> >
> >   dget -x https://mentors.debian.net/debian/pool/main/libc/libcyaml/libcyaml_1.0.2-1.dsc
> 
> I’ve had a very brief look. Two notes:
> 
> 1) The Git repo Vcs-* points to contains only the upstream code, and
> is hosted at GitHub. You probably want to host it at Salsa, not
> GitHub, and the repo needs to have a branch with the Debian packaging.

All my packages are in github and I prefer it there. I think its not
a compulsory requirement to have the package repo in salsa. Please
correct me if I am wrong.

'debian/sid' branch has been pushed for your review.

> 
> 2) You licensed the packaging as GPL-2+ while the upstream is ISC.
> While this is a valid combination, it would make upstreaming potential
> changes harder, so please consider switching to ISC or *at least*
> "GPL-2 or ISC".

Sorry, I missed it. :(
It has now been changed to ISC.
Thanks for pointing this out.

--
Regards
Sudip