control: tag -1 moreinfo
control: owner -1 !
On Sun, Feb 07, 2016 at 02:06:39PM +0000, Stefanos Harhalakis wrote:
> Dear mentors,
>
> I am looking for a sponsor for the 1.0.1-1 release of "vbackup".
> This is normally handled by Vincent Bernat but he's currently away.
Hi!
stuff I don't like and would prefer to see changed:
* please meld the 2 changelog entries, the 1 minute, 14 seconds older
one never hit the archive anyway.
* current standards-version is 3.9.7, check against it.
* what's "Set localstatedir to /var"? I can't see anything relevant in
the packaging part.
* what are those debian/.ci-name and debian/.ci-tgz files?
* in d/rules, the following is useless if you use debhelper compat 9
(you don't):
# see EXAMPLES in dpkg-buildflags(1) and read /usr/share/dpkg/*
DPKG_EXPORT_BUILDFLAGS = 1
include /usr/share/dpkg/default.mk
why did you add them?
* you bumped the dependency on debhelper, but compat is still 5.
clearly, read debhelper(7) if you bump it.
* is debian/dirs really really really needed? if it is, you build
system is broken and you may as well fix it.
* FYI, in d/rules I personally find the following comment useless
# main packaging script based on dh7 syntax
* you don't do hardening, can you consider enabling it? (see
wiki.d.o/Hardening)
* in d/copyright, the years are 2006-2012, I'm confident you want to
bump them.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature