Bug#813917: RFS: node-leaflet-formbuilder/0.2.1-1 [ITP]
Thanks Bas for the fast review.
On 06/02/16 18:02, Sebastiaan Couwenberg wrote:
Hi Ross,
Thanks for your work kosmtik and its dependencies.
I've reviewed the package, and it needs a few changes.
Please update the Source URL in the copyright file to use the URL from
the watch file, the homepage link is not as appropriate for the
copyright file.
Source URL now points at the source.
The Bug-* URLs in upstream/metadata need to be fixed too.
It appears I forgot to run $ duck :-(
Fixed (also in d/control)
Also consider filing an issue upstream to have them include a proper
license file, the only reference to the license is package.json which is
a bit sparse.
Kind Regards,
Bas
https://github.com/yohanboniface/Leaflet.FormBuilder/issues/4
I will now do a pull request.
I assume you are OK with taking the latest from git (I have not
re-uploaded to mentors).
Cheers,
Ross
Reply to: