Bug#809768: RFS: kbibtex/0.6+git7fdc0cd97c093f-1
On Mon, Jan 4, 2016 at 2:56 PM, Mattia Rizzolo <mattia@debian.org> wrote:
> control: tag -1 moreinfo
> control: owner -1 !
>
> On Sun, Jan 03, 2016 at 09:26:26PM +0100, Bastien ROUCARIÈS wrote:
>> I am looking for a sponsor for my package "kbibtex"
>
> sure.
>
>> More information about hello can be obtained from http://www.example.com.
>
> would be handy if people would at least read the template (also on the
> other RFS, btw..) :)
>
>
> stuff I don't like:
>
> * you overwrote the last upload changelog entry. don't do that.
> * I think I'd prefer a more verbose changelog, instead of "upgrade
> debian package" (at least the latter 3?)
> + add of 001-add-keywords-to-desktop.patch
> + remove README.source
> + rewrite of d/watch
> + remove of the menu file
> * in d/control you mix tab and spaces in a depends line, another
> wrap-and-sort run should fix it
> * you use compat level 9, the following is just unneded:
> +DPKG_EXPORT_BUILDFLAGS = 1
> +include /usr/share/dpkg/buildflags.mk
> * is there a reason to put private libs in a public location (instead
> of just overriding lintian naggings).
> If those a private stuff I'd expect them to be under a /directory/.
Fixed with your comments. Could you get a glimpse
Bastien
> --
> regards,
> Mattia Rizzolo
>
> GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
> more about me: http://mapreri.org : :' :
> Launchpad user: https://launchpad.net/~mapreri `. `'`
> Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Reply to: