--- Begin Message ---
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "xtrkcad"
Package name : xtrkcad
Version : 1:4.2.2-1
Upstream Author : XTrkCAD Developers <xtrkcad-fork-developers@lists.sourceforge.net>
URL : http://sourceforge.net/projects/xtrkcad-fork/
License : GPL-2, BSD Revised
Section : editors
It builds those binary packages:
xtrkcad - Model Train Track CAD Program
To access further information about this package, please visit the following URL:
http://mentors.debian.net/package/xtrkcad
Alternatively, one can download the package with dget using this command:
dget -x http://mentors.debian.net/debian/pool/main/x/xtrkcad/xtrkcad_4.2.2-1.dsc
Changes since the last upload:
xtrkcad (1:4.2.2-1) unstable; urgency=low
* new upstream version
* dep5 copyright file added
* removed obsolete debian menu entry
* removed harden patch now upstream
xtrkcad (1:4.2.1-1) unstable; urgency=low
* new upstream version, closes: #622924
* packaging updates and fixes; removes patchset for help system as is now
integrated upstream
* turnout naming fix from upstream, closes: #784423
--
Daniel E. Markle
http://ashtech.net/~dmarkle/
--- End Message ---
--- Begin Message ---
- To: 805528-done@bugs.debian.org, dmarkle@ashtech.net
- Subject: Re: Bug#805528: RFS: xtrkcad/1:4.2.2-1
- From: Gianfranco Costamagna <locutusofborg@debian.org>
- Date: Fri, 15 Jan 2016 16:51:33 +0100
- Message-id: <56991585.1040303@debian.org>
- In-reply-to: <993100744.11720696.1447932338200.JavaMail.yahoo@mail.yahoo.com>
- References: <20151119075210.GA31036@ashtech.net> <993100744.11720696.1447932338200.JavaMail.yahoo@mail.yahoo.com> <993100744.11720696.1447932338200.JavaMail.yahoo@mail.yahoo.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi Daniel, I uploaded the package as is, but please next time address
the below.
I can help you if needed.
cheers,
and thanks for your contribution to Debian
Gianfranco
On Thu, 19 Nov 2015 11:25:38 +0000 (UTC) Gianfranco Costamagna
<costamagnagianfranco@yahoo.it> wrote:
> Control: owner -1 ! Control: tags -1 moreinfo
>
>
> Hi Daniel,
>
> first review:
>
> 1) please merge the changelogs in a single entry, because seems
> that 4.2.1 never hit unstable 2) priority: extra, I guess it is
> better suitable for optional
> https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities
>
>
(at least mention in the copyright why you changed that)
> 3) VCS fields, please uncomment them and create the collab-maint
> repo (if you have troubles please tell me)
>
> I would appreciate if you could add also all the previous releases
> with something like gbp import-dscs --debsnap git-import-dsc
> --pristine-tar packagename (note: I didn't try the above) 4) please
> mention changes e.g. bump of std-version, bump of debhelper and
> compat leve, add of a new build dependency and so on
>
> 5) CMakeLists.txt is *not* a doc AFAIK, why you did add it? 6)
> bonus point if you convert the rules file with the new dh style
> e.g. why do you create a build dir?
>
>
> 7) debian/source/include-binaries, please remove
>
> 8) debian/info and debian/docs, are they useful
>
>
> this is a rules file that looks better to me %: TAB dh $@
> --parallel
>
> override_dh_auto_configure: TAB dh_auto_configure -- -D
> CMAKE_BUILD_TYPE=Release \ TAB -D CMAKE_INSTALL_PREFIX=/usr/ \ TAB
> -D XTRKCAD_USE_GETTEXT=ON \ TAB -D XTRKCAD_USE_GTK=ON \ TAB -D
> XTRKCAD_USE_GTK_CAIRO=ON \ TAB -D XTRKCAD_USE_LAYOUTCONTROL=ON ../
>
> override_dh_install: TAB dh_install TAB rm -f
> debian/xtrkcad/usr/share/xtrkcad/COPYING
>
> override_dh_installman: TAB dh_installman debian/xtrkcad.1
>
> (you can also create a packagename.manpages with "debian/xtrkcad.1"
> as entry, to avoid the two above lines)
>
> please run a debdiff between the two .deb files to see if the new
> dh is making something differ in installation
>
> and now the bad part copyright:
>
> some licenses are missing: e.g. app/bin/bitmaps/SVG/tipofday.svg +
> <ns:license
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJWmRWFAAoJEPNPCXROn13ZN3kP/3jeVufY7kUjRmOAKR9Vhjwj
VjLERXr7TIhQTGNjVGa7bZ7tooojC+HcGPzL2o6ajVmnNj6qetaq7J0qpl3eROGP
lASzFHl4sHDwUUrHPPQx0eNorCPm0VMPgweEOW9hA7uo012AXTWkTlUxAsQuWX7D
TpK48XuetR516cukl/hH1xNKAtGppkBr3EWFeBEik1qGRXUcRUoRGI3Vzke59JyO
8SXZnIQF9onQzQrK2rG62J6nbFZbbl9JnXU48nXO7eWAehxkJKBNANWL6+hBW4G+
hj+wD/Um2xuenjMIxBKRfYjAmsweeOC5NeETWRid1URhCTEeEpi7+Q88aWJGZqzw
btP3GXSACQYSU6BhQiKI9CCnH79ovAIwzE7H7MUEy/NbQ2KgjZTZWEog/dP9m/h3
rNQicuA9O6doRIFUexgDge9znY5bMR2lBTiphleLayziPUB9C8lGpartIpgmp+1G
QvCH6yFb6pQ18AzbwSaU5ItMI8HFevqc2XIpe3w8/eFbAfyfoznIs2GumBeTvduX
/74crhAf+8j3jPcUAVIV+UC6kTJE5xeiOj/AmE3ar/g6Iqn9xw3LsLQIWnMhO0lr
pjcTWS9vsD3uLAqwWGKq/u7d20EAqrSwfjsHi0ry5s9NBXbpX95qWJT0gpvmMTGF
zzs7RxLJiakvJEjcijSp
=jkHj
-----END PGP SIGNATURE-----
--- End Message ---