[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#798186: RFS: node-punycode/1.3.2+git702cc2da-1 ITP



Control: owner -1 !
Control: tag -1 moreinfo


Hi Bastien


review:


1) "As an extra tip, don't use 'extra' as 'priority' (d/control) if your
package doesn't conflict with other[1]. I suggest 'optional'.

[1] https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities";

this still applies.

2) tests/data.js: 18MB.

please consider removing or reducing the size.

a data.js.tar.xz is around 180kb.
(I wouln't have bothered, but the whole package is << 1MB

the other stuff looks good


Reply to: