Re: Bug#792144: RFS: cunit/2.1-2.dfsg-3 -- Unit Testing Library for C [ITA]
On Sun, Jul 12, 2015 at 11:33:32AM +1000, Riley Baird wrote:
> > I am looking for a sponsor for my package "cunit"
>
> Hi!
>
> I'm not a DD, so I can't sponsor your package, but I had a look, and
> here are some notes:
Hi,
Thanks for you comments, by some reason I didn't see your email when you
sent it, I found it only now, sorry for such a long timeout.
> d/control:
> -The link to your git repository doesn't seem to work.
Which one? I checked -- both works.
Maybe you thought so because there wasn't default branch, fixed:
$ git symbolic-ref HEAD refs/heads/debian
> d/copyright:
> -In the LGPL license text, you've accidentally referred to the wrong
> license:
> You should have received a copy of the GNU General Public License
Hm, this is what dh_make have in:
/usr/share/debhelper/dh_make/licenses/lgpl2
> -The conventional way of referring to the GFDL with no invariant
> sections can be seen here:
> https://sources.debian.net/src/speech-dispatcher/0.8-7/debian/copyright/?hl=113#L113
Done.
> -Are you sure that cunit is under LGPL-2 *or any later version*?
>From COPYRIGHT:
This software package 'CUnit' is Covered under GNU Library
General Public License. More about Library GPL can be found
at http://www.gnu.org/ (or) in file named LGPL-2 under
/usr/share/common-licenses/ directory and is also stated as below.
> -Make sure that the names and years are ordered. Also, if you don't know
> the year, you can put a question mark. For an example of how to order
> names and years, see this:
> https://sources.debian.net/src/2vcard/0.5-4/debian/copyright/?hl=9#L9
Done.
> d/compat:
> -This should be "9" to match the debhelper version.
Fixed, thanks.
> d/patches:
> -You should add DEP-3 headers to your patches
Since now it is in git, I chose to use git patch format, I hope that
this is ok too.
> d/README.source:
> -This is unnecessary as most packages use quilt now.
Removed.
> d/rules:
> -You can simplify this a lot by switching to the debhelper 9 style of
> d/rules
Will look at this, thanks.
> d/watch:
> -When I run uscan, it seems that there's a new upstream version
I think that this can be done later (2.1.3 new release, not a bug
fix, while this release contains bug fix), you think otherwise?
> General:
> Run lintian --pedantic -I -E. You will see a variety of tags that may
> or may not be errors.
Yep, I use this.
> Good luck getting your package into Debian,
Thanks,
Azat.
Reply to: