Bug#787148: gambatte review
Control: owner -1 !
Hi again Sergio,
first a question:
what about maintaining it under Debian Games Team?
https://qa.debian.org/developer.php?login=pkg-games-devel@lists.alioth.debian.org
review based on mentors lintian:
1) please fix the copyright file
2) please fix the watch file (ask upstream to tag releases?)
3) section Games maybe? (that one applies also to mupen64plus-qt)
4) priority extra? (that one applies also to mupen64plus-qt even if
games seems to have priority extra)
5) rules file:
ifneq arch armhf
make
endif
why?
I ask why for two reason: does qt have a problem on armhf?
well, then please correct here
Architecture: amd64 i386
I don't think you want to build qt and not ship in a binary for other archs.
6) patches/SDL*
for the sdl package you might want to add some flag such as
-I/usr/include/SDL and avoid the patch
(even if personally I prefer the patch and I'll appreciate to see it
part of upstream code)
7) changelog: "git last version" doesn't explain where did you take and
when. Please add a 0.5.0~git20150902 or whatever, but asking upstream to
tag would be better indeed
the other stuff looks good.
cheers,
G.
Reply to: