Bug#787396: Review for mupen64plus
Control: owner -1 !
Hi Sergio,
I reviewed the package, and you have already fixed many of the issues
in the mentors comments, I have only one minor nitpick:
why is Priority: extra?
https://www.debian.org/doc/debian-policy/ch-archive.html
does the package conflicts with other packages?
build issues:
src/mainwindow.cpp:414:55: warning: missing terminating " character
SETTINGS.setValue("Paths/config",
homeDir+"/AppData/Roaming/Mupen64Plus);
what about maintaining it under Debian Games Team?
https://qa.debian.org/developer.php?login=pkg-games-devel@lists.alioth.debian.org
the other stuff looks good
cheers,
G.
Reply to: