[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#797407: RFS: node-mocha-lcov-reporter/0.0.2-1 -- LCOV reporter for Mocha



Hi guys,

As an extra tip, don't use 'extra' as 'priority' (d/control) if your
package doesn't conflict with other[1]. I suggest 'optional'.

[1] https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities

I can see 2011 in 'LICENSES' and 2015 in last release on GitHub. So, I
suggest 2011-2015 for upstream copyright years (d/copyright).

Regards,

Eriberto


2015-08-31 10:35 GMT-03:00 Gianfranco Costamagna
<costamagnagianfranco@yahoo.it>:
> Control: owner -1 !
>
> Hi Julien, lets review.
>
>
>
>
> 1) changelog, please set target to unstable and refresh the timestamp
> 2) rules: please remove the newlines after the dh call (oh here we are *really* nitpicking)
>
> well, the only issue is the changelog, please fix and I'll do some testing on a built package :)
>
> cheers,
>
> G.
>


Reply to: