Hi Vincent, Live from Debconf15. On 19-08-15 21:29, Vincent Blut wrote: >> I am looking for a sponsor for my package "chrony" Please note this is a first manual inspection. Not all items are critical, most are just nitpicks or tips or questions. Please add the CVE numbers that were fixed by upstream to your changelog such that the trackers can find it automatically. TIP: if you would have done that and mention that in your RFS you would have probably found a sponsor earlier. Your priority switch from extra to optional may require a ping to somebody. I am not sure and I would need to search, so please do that yourself. Which file do you have in common with ntp? Please re-read ¹. I assume that the change of maintainership has the consent of Joachim? Wouldn't the hwclockfile stuff in /etc not warrant an debian/NEWS update? Or at the very least some help in the changelog? Doesn't this actually require a migration path? What if the /etc/chrony and /etc/adjtime are NOT answering the same? Can you please explain me how commit 1ce86d3 works (the Breaks of util-linux). I assume you tested all migrations for admins that already ran chrony as a different users as described in the README.Debian. Are the manual steps even needed? Shouldn't this go into a NEWS file instead of the README file? Line 36 of the README.Debian file ends weird now, you removed a filename but not the "and" in front. Nice to have, could you think of some autopkgtest test²? And why are the tests disabled. Unless they fail and can't be fixed, it is really recommended to run them. I think the comments you added in commit df80cd25 in the copyright file, should the "Comment" field.³ And tip to prevent the fix in commit 7245a4, use dch to write the timestamps (e.g. dch -rm) You could maybe remind upstream to update their copyright years when they make changes. Paul My TODO in the review Are the man pages regrenerated Are (new) examples installed Are (new) tests run (some seem to require network) check closed bugs ¹ https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces ² http://dep.debian.net/deps/dep8/ ³ https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#comment-field
Attachment:
signature.asc
Description: OpenPGP digital signature