Re: Looking for a mentor for the OpenSIPS project
Hi,
I didn't have time for a complete review, but two things needs to be fixed:
some copyrights are missing, ISL and some BSD2 IIRC
(I did a licensecheck * -r)
changelog should have one single entry with "initial upload closes blah" or whatever, and the target suite should be unstable, not stable.
As soon as you fix the two above I'll give it a new spin (sorry but today I didn't have much time).
Julian I would appreciate if you could do the upload, since you should already have a good knowledge about the package.
Also an ack might be appreciated, specially for the copyright file :)
cheers,
Gianfranco
Il Mercoledì 19 Agosto 2015 16:44, Răzvan Crainea <razvan@opensips.org> ha scritto:
Hi, Gianfranco!
I uploaded the latest version and it seems there are no other warnings.
I changed the format of the archive to be non-native updated some of the
files and everything seems ok now.
@Julian: thanks for checking this too. I am aware there were some issues
regarding the licencing, but these should have been solved now, since
the TLS module (the code that was using openssl) is now in a completely
new module. I added explicit licences for its code.
Best regards,
Răzvan Crainea
OpenSIPS Solutions
www.opensips-solutions.com
On 08/19/2015 04:14 PM, Gianfranco Costamagna wrote:
> Hi
>
>
> W debian-watch-file-in-native-package>* You asked me to add a watch file, but I created a native
> package. Should I remove the file?
>
> why? don't you have an orig tarball to start from?
> http://opensips.org/pub/opensips/latest/src/
>
> just use quilt source format, and make the vcs point to the orig tarballs.
>
> If you want a native package you need to explain why you need,
>
> maybe you want a dfsg tarball, in that case you download it and remove
> unneeded files (with Files-Excluded copyright feature, or with a get-orig-source target)
>
>
> W native-package-with-dash-version>* I can't change the package's name, because I will get a
> different error (latest-debian-changelog-entry-changed-to-native)
>
> yes, source/format is native, and you have a dash (because of the -1 revision)
> you need to choose
>
> P debian-watch-may-check-gpg-signature
> * is this mandatory or can be ommitted?
>
> can be omitted, but nice to have :)
>
> (nice to ask upstream to do it)
>
> cheers,
>
> G.
Reply to: