[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#775019: RFS: live-f1/0.2.11-1 [ITA]



On 01/10/2015 11:16 AM, Bafu wrote:
> Package: sponsorship-requests
> Severity: normal
> 
> 
> Dear mentors,
> 
>   I am looking for a sponsor for my package "live-f1"
> 

Hi Bofu,

Thanks for volunteering to look after this package. I had been thinking
of doing it myself, but was too busy. I am not a DD. Therefore I cannot
sponsor it. But I hope a few comments will help you along your way.

I can see that Jörg has made a few comments on your mentors package page
which you should definitely take a look at:
https://mentors.debian.net/package/live-f1

On that page you can also see that there are two information lintian
warnings that you could also try and fix:
- A watch fiile is missing (see https://wiki.debian.org/debian/watch/)
- The bumpversion-0.2.11.patch file is missing a description (see
http://dep.debian.net/deps/dep3/)

In debian/control, the link to the upstream website does not seem to
work. It may be better to link to the github project page, unless you
know of a better one?

I know it is tempting when adopting a package to take over the
debian/rules file as it was, but in the long run it may be better to
move to the more modern (and simpler) "dh $@" form of a rules file:
https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#rules
This is probably not a blocker for most sponsors though. But at least
the commented lines from the rules file template should be removed.

Unfortunately, when building the package twice, the clean target fails
because the following files are modified/created during the build and
not cleaned up:
 live-f1-0.2.11/po/live-f1.pot
 live-f1-0.2.11/po/stamp-po

Other than that, the package installs fine, and runs without error. Roll
on the 2015 season so I can see live race data :-)

Regards,

Ross

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: