Bug#769673: RFS: lletters/0.1.95+gtk2-4 [ITA, RC]
Control: tag -1 + moreinfo
Hi Dmitry,
On Sat, Nov 15, 2014 at 6:10 AM, Dmitry Borisyuk <q1werty@i.com.ua> wrote:
> Package: sponsorship-requests
> Severity: important
>
> Dear mentors,
>
> I am looking for a sponsor for the package "lletters"
>
> * Package name : lletters
> Version : 0.1.95+gtk2-4
> * URL : http://lln.sourceforge.net/
> * License : GPL-2
> Section : games
>
> It builds those binary packages:
>
> lletters - Linux Letters and Numbers - learning game for small children
>
> To access further information about this package, please visit the following URL:
>
> http://mentors.debian.net/package/lletters
>
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x http://mentors.debian.net/debian/pool/main/l/lletters/lletters_0.1.95+gtk2-4.dsc
>
> Changes since the last upload:
>
> * New maintainer (Closes: #755283).
> * Source converted to format 3.0 (quilt).
> * gettext infrastructure updated, which fixes FTBFS (Closes: #749360).
> * Use dh-autoreconf to update autotools scripts during build, thanks
> Matthias Klose <doko@debian.org> (Closes: #538667, #727450).
> * Fixed reading .wav files on 64-bit architectures (Closes: #701852).
> * Don't terminate if cannot open /dev/dsp, just disable sound instead (Closes: #712845).
> * Improved LANG variable handling, thanks Prathibha B <prathibhab@cdac.in>.
> * Manpage supplemented with FILES and ENVIRONMENT sections.
> * Configuration file (llnrc) rewritten (Closes: #703384).
> * Standards-Version bumped to 3.9.6
This is just a very brief review:
Can you also adopt lletters-media at the same time? That package is
orphaned and is a dependency of lletters. Would you consider
team-maintaining this package in the Debian Games team [1] as well?
You'll generally find it easier to find sponsors within a team.
I'm mostly concerned about the size of some of your patches in
debian/patches; it makes your package hard to review, and they're
probably obsolete as well (e.g. what's the purpose of
debian/patches/debian-changes-0.1.95+gtk2-3.2.patch when you're
running autoreconf during the build?).
While reviewing lletters, I discovered that Markus put together a
minimal, easy-to-review debdiff to fix various bugs in lletters in
#749360, so I'll go ahead and upload that first (just so we can get
some RC bugs fixed and out of our way, and so you can focus on the
packaging bits that you'd like to change). Hope that helps!
Regards,
Vincent
[1] https://wiki.debian.org/Games/Team
Reply to: