Bug#761636: review of rateintospace
Control: -1 owner !
Hi Dariusz,
(a happy new year, btw)
Some remarks regarding rateintospace.
As usual, let me know your feelings and if you think my points are valid
please fix them :)
-> dfsg
Why is it required to be repacked as dfsg? (maybe document that in
d/copyright)
-> package-version
As you took a git commit as base, you should reflect that in the
(upstream) version number, like 1.1+git<date>.
With just 1.1 you'll run into problems when you want to pack another
snapshot.
-> get-orig-source
(just a suggestion)
How's about using a scheme like in
https://wiki.debian.org/onlyjob/get-orig-source
to retrieve / repack the tarball from the git repository?
(I use such a scheme e.g for many of my packages, like
rbdoom3-bfg (still in new) [a]
[a] http://anonscm.debian.org/cgit/pkg-games/rbdoom3bfg.git
to link the package version with the upstream version and also
to fix the tar to have same md5sums on subsequent executions.
-> downloading libs
You wrote earlier
"Ok the package patched not to download libs is in git" but I couln't
find the commit... Did you push it or point me to the commit?
-> d/copyright
Files: src/game/valgrind.h
Upstream claims that this is BSD, but actually it is not.
The text does not match. Its more a mix between zlib and BSD. [1],[2]
Game-Data:
Can you please elaborate on the license situation as most likely I did
not find the relevant references.
e.g. I could not find any evidence that e.g. the music has also been
relicensed; Wikipedia [3] says only the *source code* has been "put into
freeware" , but the text quoted in the reference on the Wikipedia
article [4] says "the full rights of everything belonging to Fritz and
myself", however it would still be a non-free license:
as there Fritz Bronner says that its ok to host the CD Rom image but
"just don't charge for". Do you have more details?
(Regarding the music, at least two sound files are tagged with "composed
by Brian Langsbard". (apperantly ripped from the CD). So that would be
the author of the file, I guess.)
Sorry for nitpicking here, but this seems somehow complicated and maybe
needs documentation, also for the help of the ftp-masters.
Let me know, and we'll proceed...
[1] http://olex.openlogic.com/licenses/bsdzlib
[2]
https://fedoraproject.org/wiki/Licensing:BSD?rd=Licensing/BSD#Hybrid_BSD_.28half_BSD.2C_half_zlib.29
[3] http://en.wikipedia.org/wiki/Buzz_Aldrin%
27s_Race_into_Space#Source_code_release
[4]
http://web.archive.org/web/20070710110823/http://www.geocities.com/raceintospace/CopyrightInfo.txt
Reply to: