[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#773632: RFS: pcsx2/1.2.1-783-g1f54bb7+dfsg-1 [ITP]



On 21/12/14 19:04, Miguel A. Colón Vélez wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
>   Dear mentors,
> 
>   I am looking for a sponsor for my package "pcsx2"
> 
>  * Package name    : pcsx2
>    Version         : 1.2.1-783-g1f54bb7+dfsg-1
>    Upstream Author : PCSX2 Dev Team
>  * URL             : http://pcsx2.net/
>  * License         : GPL-3
>    Section         : games
> 
>   It builds those binary packages:
> 
>     pcsx2 - Playstation 2 emulator
>  pcsx2-dbg  - Debug symbols for PCSX2
> 
>   To access further information about this package, please visit the
> following URL:
> 
>   http://mentors.debian.net/package/pcsx2
> 
> 
>   Alternatively, one can download the package with dget using this command:
> 
>     dget -x http://mentors.debian.net/debian/pool/main/p/pcsx2/pcsx2_1.2.1-783-g1f54bb7+dfsg-1.dsc
> 
>   or go directly to the VCS:
>   http://anonscm.debian.org/cgit/pkg-games/pcsx2.git
> 
>   Regards,
>    Miguel A. Colón Vélez
> 
> 

Hi, I'm not a DD so I can't sponsor your package, but here are some
things I've noticed:

* There's a newer upstream version

* In d/changelog, urgency should be "low" since it's a new package

* Even though, technically, public domain software does not have a
copyright holder, it is typical to put the author in this field in
d/copyright anyway. Remove the phrase "Author's Note", and just leave
the author's note in the "License" field. Because there are multiple
different public domain declarations, you'll need to give them different
names, e.g. public-domain-mark and public-domain-casper.

* Unfortunately, the FTP masters require PDF files to be distributed
with source code (https://ftp-master.debian.org/REJECT-FAQ.html). You
can ask upstream if they still have it, but for now I think it would be
easier just to not package the pdf documentation.

* You don't need d/lintian-overrides when you already have
d/source/lintian-overrides.

* Upon starting the program for the first time, there is a link labelled
"Readme / FAQ (Offline/PDF)", which points to
/usr/games/Docs/PCSX2_FAQ.pdf, which does not exist (due to Debian's FHS).

* It seems that, to make use of this package, a non-free BIOS is needed.
I don't have one, so I can't really do any more testing. Also, is it
possible to make much use of this package without a non-free BIOS? If
not, the package may have to go into non-free, instead of main.

I can tell that you've gone to a LOT of work to package this. Please
don't let this last obstacle (the package review) discourage you. Thank
you, and I hope to soon see your package in Debian!

Riley Baird


Reply to: