On 12/05/2014 05:31 PM, Ruben Undheim wrote: > Hi everyone in the multimedia team, > > This new package and its counterpart (sfarkxtc) have been laying > around in the sponsorship-request "queue" approximately one month. Is > there any DD in the team who now is eager to help with some > sponsoring? The two packages are also available on mentors: > > http://mentors.debian.net/package/sfarklib > http://mentors.debian.net/package/sfarkxtc > > We are two co-uploaders and the packages are team-maintained. > Hi Ruben, I had been meaning to look at sfarklib again, but I have been a bit busy lately. So, tonight I went through it and it looks great. It builds and installs fine. A few minor suggestions: As there are no release tarballs or tags for sfarklib, it might be a good idea to provide a get-orig-source target in d/rules so that we can recreate and create new orig-tarballs consistently within the team in the future. It is also a good idea to run $cme fix dpkg-control on d/control. Diff files look better this way when you add or drop dependencies and uploaders. Whilst you are at it, a small grammatical error could be fixed in the description for the -dev package: "for developing applications that depends on" > "for developing applications that depend on". The -dev package description also promises some HTML docs that are not delivered :-) As I said before I will be happy to co-maintain this with you in the Debian Multimedia team. I am now a DM. So if we can convince a sponsor to upload sfarklib, then after it passes the new queue we may be able to convince the same sponsor to give me upload permission sometime. I will take a look at sfarkxtc next. Regards, Ross
Attachment:
signature.asc
Description: OpenPGP digital signature