Bug#771774: RFS: libmongo-client/0.1.8-2 [ITA]

[Gergely Nagy <algernon@madhouse-project.org>]

>>>>> "Jörg" == Jörg Frings-Fürst <debian@jff-webhosting.net> writes:

    >> * The build: target was there for a reason. Without it, we will build
    >> the arch-indep stuff by default too, which is something we want to
    >> avoid.
    >> 
    >> For example, it will FTBFS on buildds, because they do not install
    >> build-depends-indep. And we really don't want doxygen and graphviz in
    >> B-D, because those pull in a shitload of stuff, to build docs that
    >> will be discarded by buildds anyway.

    Jörg> I fully agree with you.
    Jörg> But where are the problem? The package has no FTBFS and I don't change
    Jörg> your -arch / -indep division. 

    Jörg> Please can you specify your minds.

Ah, yes, now I remember. This was done for backporting purposes, so the
package could be built on older releases where sbuild didn't call
build-arch yet, but used build. For unstable, dropping the build target
as you did is fine, indeed.

    >> * Why move --dbg-package from DH_OPTIONS to an override?

    Jörg> --dbg-package is only needed in dh_strip[1]. 

Yes. But it works fine in DH_OPTIONS too, without any ill side-effects,
and is shorter there. (Personal thing, but I hate overrides, and if
there's another way to do what I want, which isn't convoluted, I'd
choose that)

But override or DH_OPTIONS, in this case, doesn't matter.

The updated package looks fine, good job! One thing you may wish to
change is the "Source:" stanza in debian/copyright. While I intend to
restore the git URL there (I just need to reinstall cgit), it currently
doesn't work, and github is the canonical one nowadays.

-- 
|8]