Bug#736952: RFS: ming/1:0.4.5-1.1 [NMU][RC]
On Tue, Jan 28, 2014 at 4:30 PM, Gabriele Giacone <1o5g4r8o@gmail.com> wrote:
> On Wed, Jan 29, 2014 at 1:04 AM, Vincent Cheng <vcheng@debian.org> wrote:
>>> Alternatively, one can download the package with dget using this command:
>>>
>>> dget -x http://mentors.debian.net/debian/pool/main/m/ming/ming_0.4.5-1.1.dsc
>>>
>>> or clone
>>>
>>> https://github.com/gg0/libming-debian
>>>
>>> Changes since the last upload:
>>>
>>> * Non-maintainer upload.
>>> * Fix FTBFS due to ungif linking (Closes: #733373).
>>> * Fix FTBFS on Hurd and against recent bison versions (Closes: #736162).
>>> * Strip non debian/ files.
>>
>> Why is this necessary? This adds unwanted noise to debdiff's output,
>> and shouldn't be in a NMU; please revert this.
>
> Reuploaded, pushed changes. Also reverted unused patches rename.
>
>>> * Switch from superseded automake1.10 to automake.
>>>
>>> ming has been removed from testing due to #733373.
>>> Maintainer is unresponsive.
>>>
>>>
>>
>> Regards,
>> Vincent
>
> Thanks for reviewing.
A few more comments now that I've had a chance to take a closer look
at this package (somewhat nitpicky):
- Your package contains a .gitignore file that wasn't there before
(this sticks out like a sore thumb with debdiff)
- Please close #724417 in d/changelog (the automake related build-dep update)
- I'd actually recommend splitting out the ungif linking patch from
03_py_ext (and as an added bonus, include a DEP-3 header with this new
patch)
Stuart, assuming you have no objections (or if you don't respond),
I'll be uploading this to the delayed queue once the above issues are
fixed.
Regards,
Vincent
Reply to: