Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
Hi Joseph,
On Mon, Jan 20, 2014 at 2:33 PM, Joseph Herlant <herlantj@gmail.com> wrote:
>> - Why "Architecture: any" if there aren't any arch-specific files in
>> your package?
>
> As it means any architecture supported by debian and that it is the "most
> frequently used" regarding debina policy 5.6.8. I thought it could
> stay like this.
> What's your advice for this?
> Use "all" instead of "any"?
Yes, use "all" instead. "any" will cause your package to be compiled
on all Debian release architectures and introduce different binary
packages of gnome-shell-pomodoro for every supported arch; "all" will
save buildd time and will only install a single binary package for use
on all archs.
>> - Description synopsis (the short one-liner) should be <60 chars (Policy 3.4.1)
>
> Actually it's 80 chars but You're right it was too long. I shorted it.
Ack, 80 chars, sorry.
It still doesn't abide by devref guidelines though; you should remove
"This" and the period at the end of your synopsis (devref 6.2.2 [1]).
Also, your description has a few other minor issues (e.g. inconsistent
capitalization of "Pomodoro Technique". You may wish to ask for a
review of your package synopsis and description via
debian-l10n-english@lists.debian.org (at this point I'm just being
pedantic, so ignore this if you want, I suppose, but ideally fix the
synopsis at least).
> The updated package has been updated to mentors:
> http://mentors.debian.net/debian/pool/main/g/gnome-shell-pomodoro/gnome-shell-pomodoro_0.8.0-2.dsc
Please merge your changelog entries into a single one (version
0.8.0-1). You also don't need to reference me in your changelog entry.
:)
Also, gnome-shell-pomodoro should not depend on intltool and
libglib2.0-dev. Those packages are needed to build
gnome-shell-pomodoro (hence why they are listed in build-depends), but
not for running g-s-pomodoro itself.
Regards,
Vincent
[1] https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis
Reply to: