Bug#719801: Acknowledgement (RFS: roundup/1.5.0-1)
On Thu, Oct 17, 2013 at 5:20 PM, Kai Storbeck <kai@xs4all.nl> wrote:
> I have updated roundup_1.5.0-1 per the 17th of October with a few
> changes after getting feedback by Sebastian Ramacher.
Hi Kai,
I came across your package on mentors, and I am interested in
sponsoring it. Though, I ran into a few issues that need to be fixed
first.
1) You seem to maintain the packaging in a VCS:
> * Move to git-dpm packaging
In that case, it is very useful to include Vcs-{Git, Svn, Bzr} and
Vcs-Browser fields in debian/control:
https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-VCS-fields
2) There are minified version of JQuery and Bootstrap located in:
share/roundup/templates/jinja2/static
As you already remove other copies of JQuery in other templates, you
probably already know that you should use the system copies.
Additionally, minified JavaScript objects that are installed with the
binary package must be built from source. Same goes for the minified
Bootstrap css files in that directory.
Also, as long as these files are shipped in the tarball, their license
information needs to be documented in debian/copyright.
3) You seemed to remove some necessary bits from your postrm to clean
up when purging the package. From piuparts:
3m20.5s ERROR: FAIL: Package purging left files on system:
/etc/roundup/ owned by: roundup
/etc/roundup/service/ not owned
/etc/roundup/service/log/ not owned
3m20.5s ERROR: FAIL: Installation, upgrade and purging tests.
There maybe further issues. This is just as far as I got. I'd be happy
to do a closer review and hopefully sponsor the package once these
problems are fixed.
Thanks for your work on Debian!
-- Andrew Starr-Bochicchio
Ubuntu Developer <https://launchpad.net/~andrewsomething>
Debian Developer <http://qa.debian.org/developer.php?login=asb>
PGP/GPG Key ID: D53FDCB1
Reply to: