Bug#735685: RFS: libnftables/0.0.0~20131209-1 [ITP]
On 17 January 2014 17:59, Neutron Soutmun <neo.neutron@gmail.com> wrote:
> Hello,
>
> I have no right to upload, but I'm interested in "nftables" also.
> therefore, I have both dget and git clone your source package for
> testing and reviewing.
>
> Below is my review.
>
Thanks you for the review!
Some comments below.
> * debian/control:
> + could bump the standards-version to 3.9.5 as lintian has warned right now.
> (found a revert commit in git :P)
Fixed, but for the next version of the package.
> + cosmetic, please apply wrap-and-sort -sa
>
I don't like it. If not required, I would leave this as is.
> * debian/copyright:
> + forgot the debian/* license
isn't needed, since 3.9.3.
> + the upstream license could be GPL-2+ as mention in the COPYING file
fixed, for the next version of the package.
>
> * debian/watch:
> + I know you plan the watch file for the upstream first release but
> it could be changed later, for my suggestion is
>
> === 8< ===
> opts=uversionmangle=s/^/0.0.0~/ \
> http://ftp.netfilter.org/pub/libnftables/snapshot/libnftables-(\d\S*).tar.bz2
> === 8< ===
>
> just track the snapshot tarball, I know it's nonsense but it's not
> broken watch file :)
>
Changing this will require another change in a [near] future. I don't
see the point.
> * vcs-git:
> + cloned, the "git buildpackage -S" is failed. the upstream tag
> << upstream/0.0.0_20131209 >> is missing.
>
I added the tag :)
> Hopefully, the package will be sponsored soon. Good luck.
>
Again, thanks!
--
Arturo Borrero González
Reply to: