Bug#712118: marked as done (RFS: splix/2.0.0+svn308-1)
On 3 January 2014 12:14, Didier 'OdyX' Raboud <odyx@debian.org> wrote:
> I'm awfully sorry to have failed to answer you earlier, let's correct
> that now.
That's no problem, I've been caught up with work stuff so I dropped the ball
as well.
> Could you make your git repository available somewhere so that I could
> review the git workflow itself too?
I've uploaded it at
https://bitbucket.org/lniccoli/splix-package.git
> Now for the review:
>
> * I find the debian/changelog entry quite messy and I do prefer to hand-
> edit it after git-dch to make it less redundant and more useful to users
> and other developers. In your case, at least two Standards-Version
> updates are redundant, same goes for upstream imports; I would write it
> that way for example:
I tidied up the changelog and fixed the urgency (I realized reading your mail
that it was set to medium, I don't know how that happened).
I also updated the dsc on mentors.debian.net.
> * Otherwise, I only see the Vcs-Git and Vcs-Browser fields missing, but
> it's arguably not possible to set them before the git repository is
> available. :-)
I can either set them on the next upload or rewrite the release commit after
having set them once the alioth repository is active.
> * In short; it is mostly uploadable! :-)
Great!
> Your alioth account is lultimouomo-guest, right ? Can you request to get
> added to the collab-maint alioth project as documented on
> https://lists.debian.org/debian-devel-announce/2012/01/msg00006.html
> ? I will then request your inclusion in this (lightweight and general-
> purpose) project, so that you can maintain splix as a collab-maint git
> repository.
Yes, my account is lultimouomo-guest. I requested to join collab-maint,
could you write the confirmation mail to nm@debian.org?
Thanks,
Luca
Reply to: