Re: RFS: python-snappy

2011/11/1 Jakub Wilk <jwilk@debian.org>

* Shell Xu <shell909090@gmail.com>, 2011-10-31, 23:55:

http://mentors.debian.net/package/python-snappy

There still a lintian INFO about desc, but I copied it from google code. Do I need to fix it?

The sentence lintian is complaining about (using-first-person-in-description) is: "Snappy is widely used inside Google, in everything from BigTable and MapReduce to our internal RPC systems." This certainly doesn't make sense in a description of a _Debian_ package.

Alternatively, one can download the package with dget using this command:

dget -x http://mentors.debian.net/debian/pool/main/p/python-snappy/python-snappy_0.3.2-1.dsc

I'm not interested in sponsoring this package, but here's my very quick review:

You probably want to build-depend on "python-all-dev", not "python-dev, python2.6-dev, python2.7-dev".

Please consider building also a package for Python 3.X, as upstream seems to support it, too.

I think the long description is a bit too verbose. The part that refers to the underlying library is even longer that description of libsnappy1 itself.

In debian/copyright, you don't need to repeat copyright information in the License field.

debian/docs is empty, so... just delete it.

Remove libsnappy1 from Depends. This dependency will be automatically generated by dpkg-shlibdeps.

The binary package doesn't depend on python. It's because you forgot to add ${python:Depends} to Depends.

--
Jakub Wilk

--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20111031163324.GA1822@jwilk.net" target="_blank">http://lists.debian.org/20111031163324.GA1822@jwilk.net