Re: RFS: pygame
- To: debian-mentors@lists.debian.org
- Subject: Re: RFS: pygame
- From: Ansgar Burchardt <ansgar@debian.org>
- Date: Thu, 06 Oct 2011 10:58:01 +0200
- Message-id: <87k48iv6na.fsf@marvin.43-1.org>
- Mail-followup-to: debian-mentors@lists.debian.org
- In-reply-to: <CACZd_tAiFGT5Qbkv9Q2Y9UtMzDiRieNTATtAeSD93RqMw9iFGw@mail.gmail.com> (Vincent Cheng's message of "Fri, 30 Sep 2011 15:42:42 -0700")
- References: <CACZd_tBM=WfRV4XQz4oHKah5v7idczdujF0oEbvmgGmy7WVLFA@mail.gmail.com> <878vpjkq9y.fsf@deep-thought.43-1.org> <CAKTje6HLZa77VyXwt8uwj7-q8wx=pZ2NHDnCeqR5abp0kkZRug@mail.gmail.com> <CACZd_tA2uDg28-VEU-FyCPZHda58_WpzaDy4LCzDQeTXFnm1Qw@mail.gmail.com> <CAKTje6Fwm6VgfS-9newXvvcdg_YGCsLrjVXdLW+GCwbn_rm4tQ@mail.gmail.com> <CACZd_tDaQU6dVp7ZPxgj7+WLtDHXSKh2_-aYTdksFr-R-8mpNg@mail.gmail.com> <87r52xonzc.fsf@deep-thought.43-1.org> <CACZd_tAiFGT5Qbkv9Q2Y9UtMzDiRieNTATtAeSD93RqMw9iFGw@mail.gmail.com>
Vincent Cheng <vincentc1208@gmail.com> writes:
> On Fri, Sep 30, 2011 at 11:59 AM, Ansgar Burchardt <ansgar@debian.org> wrote:
>> Vincent Cheng <vincentc1208@gmail.com> writes:
>>> All right, repacked and re-uploaded to mentors.d.n:
>>>
>>> $ dget -x http://mentors.debian.net/debian/pool/main/p/pygame/pygame_1.9.1release+dfsg-2.dsc
>>
>> I am not an expert on python packages, but it looks okay to me with one
>> exception: debian/rules hardcodes python versions (2.6 and 2.7). This
>> should ideally not be done and I can see two ways to avoid this: either
>> create the symlink before running setup.py so that it will be installed
>> the normal way (remember to remove it later), or use shell globbing to
>> match $(CURDIR)/debian/python-pygame/usr/lib/python* instead of giving
>> explicit versions.
>
> Fixed.
Sorry, I did not test this myself before sending my earlier mail, but
the build process copied the font file referenced by the symlink
(instead of copying only the symlink itself).
Could you try the other alternative then?
Regards,
Ansgar
Reply to: