[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sxiv



* Daniel Echeverry <epsilon77@gmail.com>, 2011-09-11, 03:07:
I tried to build the package with DEB_BUILD_OPTIONS=noopt, but -O2 was used as optimization anyway. Could you please fix that?
Please check out:
http://mentors.debian.net/**debian/pool/main/s/sxiv/sxiv_**0.9-1.dsc<http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_0.9-1.dsc>
Hmm, so you dropped -O2 unconditionally, which is not quite what I asked. Normally software should be build with -g -O2 (note that sxiv doesn't use -g, which is another thing to fix).

Please see Debian Policy 10.1 and 4.9.1 for details.

Fixed, please check out again:
http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_0.9-1.dsc

Okay, so this addressed my second concern (missing -g), but not the first one (respecting DEB_BUILD_OPTIONS=noopt).

Also, can I have a more descriptive changelog entry? The sole patch name doesn't give one any clue what the change was made.

--
Jakub Wilk


Reply to: