Re: [Fwd] Bug#621966: hasciicam: FTBFS: hasciicam.c
On Tuesday 26 April 2011 11:53:58 Jaromil wrote:
dear George,
Dear Jaromil,
Let's skip mediterranean style dramas.
I had a look at it since it is a relatively simple
package one can quickly learn to grasp and you fix a
FTBFS, though the diff compared to what we have in
sid is rather large. I also tested it to the extend
'works for me'. Few pointers:
1) upstream ChangeLog is meager.
(new header videodev2.h used ... at least?)
2) debian/changelog does not close the proper bug.
you can close the manually, but still.
3) debian/copyright lacks the copyright holders of
of ftplib.[h|c]
4) you don't use ftplib already available in Debian, but
embed an outdated copy of it instead. Headers seem identical,
but you miss a check in ftplib.c (see diff). Not a big deal though,
but folding these inside your project places burden to security
team to identify and update in case of flaw.
The rest seems just fine.
Note, the package in sid also lacks 3), but I'd rather
have this fixed. While at it, what else do you intend to fix?
Thanks for your time.
--
pub 4096R/0E4BD0AB <people.fccf.net/danchev/key pgp.mit.edu>
Reply to: