Re: Fwd: RFS: herculesstudio

[Thomas Goirand <thomas@goirand.fr>]

On 04/10/2011 04:40 AM, Liang Guo wrote:
> CC to debian-mentors and BUG:585510
> 
> On Sat, Apr 9, 2011 at 1:07 PM, Thomas Goirand <zigo@debian.org> wrote:
>> 1/ Can you use the new DEP5 format for your debian/copyright?
>>
> Done
> 
>> 2/ The policy is now 3.9.1.
> Done, actually current policy is 3.9.2 now, but lintian don't support
> it yet. so I still use 3.9.1
> 
>>
>> 3/ I think you should remove useless comments in your debian/rules, it
>> would improve readability. Like:
> Unnecessary comments are removed.
> 
>> 4/ I tried the GUI, and it seemed vaguely working, that's enough for me.
>> But where exactly in the Gnome menu did it install???
>>
> I added herculesstudio.desktop, so Hercules Studio can be found at
> System or System/Simulator now.

Thanks for these changes. It was mostly cosmetic (apart from the
.desktop which was really missing...).

> And I've push my changes to git.d.o, you can check it at:
> 
> git://git.debian.org/git/collab-maint/herculesstudio.git
> 
> Thanks and Regards,

That's great if you use Git, I maintain all of my packages this was as
well. But next time you ask for sponsorship, please fill the Vcs-Git and
Vcs-Browser fields of debian/control accordingly.

As the Vcs-* fields were not blockers, I did upload the package to SID
for you. Please correct this in your Git for the next upload. :)

Thanks for your interest in Debian, and for your work. I am now
confident that you deserve the DM status, and I can for sure vouch for
you, in a more definitive way that I did on my first message.

Thomas