[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: mediadownloader (retry)



Hi,

> I am looking for a sponsor for my package "mediadownloader".
> 
> * Package name    : mediadownloader
>   Version         : 1.5.0-1
>   Upstream Author : Marco Bavagnoli lil.deimos@gmail.com
> * URL             : http://mediadownloader.cz.cc
> * License         : gpl3
>   Section         : graphics
> 
> It builds these binary packages:
> mediadownloader - Search, preview, download with Google Image and YouTube
> 
> The package appears to be lintian clean.

[...]

That may well be true, but it doesn't even build:

g++ -c -pipe -O2 -D_REENTRANT -Wall -W -DPHONON_LIB -DQT_OPENGL_SUPPORT -DQT_NO_DEBUG -DQT_WEBKIT_LIB -DQT_PHONON_LIB -DQT_XML_LIB -DQT_OPENGL_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtOpenGL -I/usr/include/qt4/QtXml -I/usr/include/phonon -I/usr/include/qt4/QtWebKit -I/usr/include/qt4 -Imain -I/usr/include/qt4/phonon_compat -I/usr/X11R6/include -I.build -I.build -o .build/browse.o main/browse.cpp
main/browse.cpp:20:20: fatal error: QWebView: No such file or directory

Apart from this major problem, please consider the following changes, some of
which I already suggested in an earlier review:

- You might want to acknowledge several previous reviewers in your changelog.
- debian/copyright: It would be nice if it were converted to DEP-5 format.
- debian/rules: A debian/install (and maybe debian/dirs) should help to simplify
  your rules, and moving to the simplified debhelper-7 version would be even
  better.

Best regards,
Michael

Attachment: pgpt4m8PbWBXy.pgp
Description: PGP signature


Reply to: