[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: qmagneto



Hi,

[...]

I finally got around to take a look at your package. One basic problem must be
solved at first: several files lack license and copyright information:

src/changethumbimpl.h
src/application.cpp
src/changethumbimpl.cpp
src/channeliconitem.h
src/application.h
src/releaseversion.h
src/expandedpixmap.cpp
src/expandedpixmap.h
src/channeliconitem.cpp

Furthermore, the following issues should be addressed:

- debian/copyright: Nothing is said about the license of Debian packaging;
  likely it takes the same license as upstream code, but that should be stated
  explicitly. Furthermore please consider conversion to DEP5 format. Furthermore
  it's not even said where this software can be downloaded from.
- debian/docs is empty (should probably be removed).
- debian/watch does nothing.
- Your build rules are semi-broken it seems: the entire build is performed
  twice.
- Building the package yields a large number of warnings; as you are upstream,
  please address these.
- Please make sure your package is lintian-clean.

Best regards,
Michael

Attachment: pgpJvL_DQpOUI.pgp
Description: PGP signature


Reply to: