Thanks a lot for the review, I am actually new to packaging library files. I will do what you have pointed out and then submit another RFS in a week Bilal Akhtar On Fri, 2010-08-20 at 20:13 +0200, gregor herrmann wrote: > On Fri, 20 Aug 2010 10:43:52 +0300, Bilal Akhtar wrote: > > > * Package name : liboauth > > Version : 0.8.4-1 > > Upstream Author : Robin Gareus <robin@gareus.org> > > * URL : http://liboauth.sourceforge.net/ > > * License : MIT > > Section : libs > > > > The package can be found on mentors.debian.net: > > - URL: http://mentors.debian.net/debian/pool/main/l/liboauth > > - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free > > - dget http://mentors.debian.net/debian/pool/main/l/liboauth/liboauth_0.8.4-1.dsc > > Thanks for your work! > > Preface: I'm not very familiar with shared libs, so I'd like to have > someone else take another look at the package (maybe pabs, who > commented in May?). > > Quick remarks: > * debian/copyright: > - The download URL is wrong (contains an (old) > version), I'd use just http://liboauth.sourceforge.net/ > - The files have different years of copyright, I think "2007-2010" > would be the appropriate superset. > * debian/liboauth-dev.install: Do we need the .a/.la files? [0] > * debian/control: > - Current Standards-Version is 3.9.1. Please update and check if > changes are necessary. [0] > - Just curious: why are locales and locales-all needed? > - short descriptions: "C library implementing the OAuth 1.0 > specification" would sound better in my (also non-native) ears. > > When I build the package openssl gets installed (but it doesn't seem > to be used). > > The package doesn't build for me (in an up2date cowbuilder chroot): > > #v+ > Making all in tests > make[2]: Entering directory `/tmp/buildd/liboauth-0.8.4/tests' > gcc -DHAVE_CONFIG_H -I. -I../src -I./../src -Wall -Wall -g -O2 -c -o oauthexample-oauthexample.o `test -f 'oauthexample.c' || echo './'`oauthexample.c > /bin/sh ../libtool --tag=CC --mode=link gcc -Wall -Wall -g -O2 -o oauthexample oauthexample-oauthexample.o ../src/liboauth.la -lssl > libtool: link: gcc -Wall -Wall -g -O2 -o .libs/oauthexample oauthexample-oauthexample.o ../src/.libs/liboauth.so -lssl > /usr/bin/ld: cannot find -lssl > collect2: ld returned 1 exit status > #v- > > Hm, looks like tests/Makefile* has "-lssl" hardcoded. > (Quick test: after replacing "-lssl" with "@LIBOAUTH_LDFLAGS@" in > tests/Makefile.am it builds.) > > And then we have some lintian messages: > I: liboauth-dev: hyphen-used-as-minus-sign usr/share/man/man3/oauth.3.gz:390 > (and 4 others) > I: liboauth0: no-symbols-control-file usr/lib/liboauth.so.0.6.0 > > > [0] > /usr/share/doc/debian-policy/upgrading-checklist.txt.gz: > says e.g. > > 10.2 > Libtool `.la' files should not be installed for public libraries. > If they're required (for `libltdl', for instance), the > `dependency_libs' setting should be emptied. Library packages > historically including `.la' files must continue to include them > (with `dependency_libs' emptied) until all libraries that depend > on that library have removed or emptied their `.la' files. >
Attachment:
signature.asc
Description: This is a digitally signed message part