[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: python-django-photologue



Hi Ihor,


This is my initial review:

changelog:
----------

* replace "unstable" with "UNRELEASED" in all entries except in the first entry
* put "closes" in the first entry


control:
--------

* priority field must be 'optional' instead of 'extra'
* upgrade standards version to newer version
* add VCS fields


copyright:
----------

* the maintainer field is about upstream and not about you.
* you forgot the files field in the upstream Files section.
* you don't need to repeat the copyright text because of the year, you can use:

  Copyright: 2007-2009, Justin Driscoll <justin.driscoll@gmail.com>

* You don't need to repeat the license text, just use the License section: 

  License: BSD
    On Debian GNU/Linux systems, the complete text of the BSD License
    can be found in `/usr/share/common-licenses/BSD'


watch:
------

I think this way better:

opts=\
downloadurlmangle=s|.*[?]name=(.*?)&.*|http://django-photologue.googlecode.com/files/$1|,\
filenamemangle=s|[^/]+[?]name=(.*?)&.*|$1| \
http://code.google.com/p/django-photologue/downloads/detail[?]name=django-photologue-(.*)\.zip.*





Cheers,

-- 
Marcelo Jorge Vieira
xmpp:metal@jabber-br.org
http://metaldot.alucinados.com


Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: