[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: fdclone (updated package)



> I see. If upstream changes the configuration file format often you may
> want to look at implementing a Config::Model backend for it so that
> you can safely upgrade users configuration files automatically.
>
> Also, the README.Debian contains bunch of unneeded detail. A lot of
> the listed changes are what Debian users would expect because of
> Debian policy. I would remove points 1-3, 5-6, 8, 10.
>
ok, I'll take into account.

>>> Minor nitpick, the -r option means recursively remove a directory.
>>> Since you are removing a file, no need to use it :)
>>
>> ok. you win. :)
>
> It wasn't my intention to win, just to educate you a little ;)
>
hehe,  thanks! :)

>>> In comparison to yours, it doesn't mention the following irrelevant detail:
>>
>> About the changelog, I've followed your advice and add a item. Finally:
>
> Cool
>
> Please send the patches upstream too.
>
> Also, looking at the output of `whohas fdclone`, I found some more
> patches you may want to let upstream know about:
>
> http://fink.cvs.sourceforge.net/viewvc/fink/dists/10.4/stable/main/finkinfo/utils/fdclone.patch?revision=HEAD&view=markup
> http://trac.macports.org/browser/trunk/dports/sysutils/FDclone/files/patch-Makefile.in.diff

ok, I'll review them and send to the upstream what think about them. Thanks!

Regards,

--
Elías Alejandro


Reply to: