Re: RFS: minidlna
Hi,
Thanks a lot for your comments, I really appreciate you taking the time.
Fernando Lemos wrote:
> I'm not a DD or a DM, but here's my (very superficial) review, as I'm
> mildly interested in this package.
>
> * It seems that you are missing Build-Depends on libavcodec-dev and
> libavutil-dev.
You're absolutely right; I missed it because it wasn't mentioned in the
INSTALL file and libavformat-dev pulls both packages as its dependencies
(so the pbuilder build did not fail). I fixed it in my git repository
[1] and will upload it as version 1.0.18-2 as soon as I'm done with a
few more changes (a man page for minidlna.conf and a better
configuration file).
> * lintian -I is mosly clean, except for:
>
> I: minidlna: spelling-error-in-binary ./usr/bin/minidlna Psychadelic Psychedelic
>
> I believe that's really not a big deal, though (you might want to let
> upstream know anyways).
Fixed too, thanks. I will send it upstream, along with a few other
changes they may want to include.
Cheers.
---
[1] http://gitorious.org/minidlna/minidlna
--
Benoît Knecht
Reply to: