Re: RFS: mpg321 (updated package)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi
Dne Mon, 25 Jan 2010 12:17:39 +0200
Nanakos Chrysostomos <nanakos@wired-net.gr> napsal(a):
> I am looking for a sponsor for the new version 0.2.11-2
> of my package "mpg321".
>
> It builds these binary packages:
> mpg321 - Simple and lighweight command line MP3 player
>
> The package appears to be lintian clean.
>
> The upload would fix these bugs: 566544
>
> The package can be found on mentors.debian.net:
> - - URL: http://mentors.debian.net/debian/pool/main/m/mpg321
> - - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - - dget
> http://mentors.debian.net/debian/pool/main/m/mpg321/mpg321_0.2.11-2.dsc
>
> I would be glad if someone uploaded this package for me.
Please do not send same email several times, it just upsets people.
Comments about the package:
- - there is no reason to build depend on quilt when using 3.0 (quilt)
source format, you also don't need to fiddle with quilt in
debian/rules
- - please use DEP-3 compliant patch headers
Your patch:
++ //tempsample = mad_f_mul(*left_ch++, options.volume);
++ tempsample = (mad_fixed_t) ((*left_ch++ *
(double)options.volume)/MAD_F_ONE);
Seems obviously wrong, because one of key features of mpg321 is that it
uses just fixed-point calculation, while you introduce floating point
arithmetic by this patch.
- --
Michal Čihař | http://cihar.com | http://blog.cihar.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (GNU/Linux)
iEYEARECAAYFAktdpm8ACgkQ3DVS6DbnVgSJvgCfReurIJwojXYH3Lb9jRT6pZr9
4ZcAmwRhggp3yRd5GSUI3kaNwKPLE0en
=58Oj
-----END PGP SIGNATURE-----
Reply to: