(IANADD, review only) On Mon, Jun 29, 2009 at 11:32:00PM +0800, xiangfu wrote: > Dear mentors, > > I am looking for a sponsor for my package "xburst-tools". > > * Package name : xburst-tools > Version : 20090630-1 > Upstream Author : Xiangfu Liu <xiangfu.z@gmail.com> > * URL : http://github.com/xiangfu/xburst-tools > * License : GPLv3 > Section : misc > > It builds these binary packages: > xburst-tools - host tool for Ingenic XBurst CPU USB boot and NAND flash access Is this meant to be a native package? It doesn't look like it - in which case you need to have an xburst-tools_2090630.orig.tar.gz file with the upstream sources in (even if you are upstream), and then when you build the package you will get a diff.gz file. [1] Other things you also need to address: * you need to file an ITP bug and declare it in your changelog [2] * you should be working to standards version 3.8.2 by now * the package descriptions need some work. You might like to ask for a review at the debian-l10n-english mailing list [3]. * if you're using debhelper, you should have a ${misc:Depends} dependency * the copyright file should make it clearer how this software is licensed * remove the dh-make hints from your files, like in debian/copyright * tidy your rules file and remove the commented-out calls, and other cruft * add a watch file * please use the lintian tool, there are many warnings: W: xburst-tools source: out-of-date-standards-version 3.8.0 (current is 3.8.2) W: xburst-tools source: changelog-should-mention-nmu W: xburst-tools source: source-nmu-has-incorrect-version-number 20090630-1 W: xburst-tools source: native-package-with-dash-version P: xburst-tools source: source-contains-prebuilt-binary xburst_stage1/debug.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage1/common.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage2/boothandler.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage2/nandflash_4750.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage2/serial.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage2/udc.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage2/head.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage1/main.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage2/nandflash_4740.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage1/xburst_stage1.elf P: xburst-tools source: source-contains-prebuilt-binary xburst_stage1/board_4740.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage1/head.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage1/board_4750.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage2/cache.o P: xburst-tools source: source-contains-prebuilt-binary xburst_stage2/xburst_stage2.elf P: xburst-tools source: source-contains-prebuilt-binary xburst_stage2/main.o W: xburst-tools: binary-without-manpage usr/bin/xburst_tools E: xburst-tools: FSSTND-dir-in-usr usr/man/ I: xburst-tools: package-contains-empty-directory usr/man/man1/ I: xburst-tools: package-contains-empty-directory usr/share/xburst-tools/ P: xburst-tools: copyright-refers-to-symlink-license usr/share/common-licenses/GPL W: xburst-tools: copyright-lists-upstream-authors-with-dh_make-boilerplate W: xburst-tools: copyright-contains-dh_make-todo-boilerplate W: xburst-tools: description-synopsis-might-not-be-phrased-properly W: xburst-tools: new-package-should-close-itp-bug W: xburst-tools: wrong-bug-number-in-closes l3:#nnnn (use [4] if you don't understand them) 1: http://www.debian.org/doc/manuals/developers-reference/pkgs.html#sourcelayout 2: http://www.debian.org/devel/wnpp/ 3: http://lists.debian.org/debian-l10n-english/ 4: http://lintian.debian.org/tags.html -- Jonathan Wiltshire 1024D: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3 A903 CA6B EA3E DB80 0B52 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
Attachment:
signature.asc
Description: Digital signature