On Sun, Apr 26, 2009 at 07:41:09PM +0200, Reinhard Tartler wrote: > AFAIUI sponsor requests should go to debian-mentors. Please not that I'm > not a mentors regular, so I'm not really sure of the exact procedures > here. Nevertheless, I'm copying the mailing list. I know, but you told me before to just answer to the ITP, so I did so. > My preliminary review of > http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=radare > * spurious configure target, please remove it. done in 1.3-3 > * build-target could be improved, e.g. by placing both variants in > different make targets. also consider a VPATH build. there is build-gtk, built-nongtk and build-doc target in 1.3-3 > * clean rules unpatches before running clean. This will break if you > had modifications to the clean parts of the build system. You don't > do that here, but I'm mentioning it just in case. I didn't change this, since I'll ask upstream to fix problems in the clean parts of the build system. The lua change is just needed because it's debian specific. > In general, run the tool `devscripts -r .` in the top level root > directory to get a brief license check. AFAIUI this is the tool > ftpmaster uses to examine NEW packages. uhm where do I get devscripts? The devscripts package does not contain it! > I fear debian/copyright needs to mention all this. Are there other > opinions on that from mentors? I've updated debian/copyright with all licenses I found. -- Sebastian
Attachment:
signature.asc
Description: Digital signature