On Thu, Mar 12, 2009 at 11:13:36AM +0000, Jonathan Wiltshire wrote: > Hi, > > On Thu, Mar 12, 2009 at 01:46:01AM +0100, Remy Dautriche wrote: > > It builds these binary packages: > > clewn - GDB support for the vim editor > > Please make it more clear in the short description (the bit I see in > package searches) that this only works with gVim. > I will modify the short description. > Your package also FTBFS in a pbuilder chroot because upstream's makefile > appears to call vim (therefore it should be a build-dep): > > ---8<--- > make[4]: Entering directory `/tmp/buildd/clewn-1.14/runtime' > clewn help tags file generation > /bin/sh: vim: command not found > make[4]: *** [help-tags-generation] Error 127 > make[4]: Leaving directory `/tmp/buildd/clewn-1.14/runtime' > make[3]: *** [install-data-am] Error 2 > make[3]: Leaving directory `/tmp/buildd/clewn-1.14/runtime' > make[2]: *** [install-am] Error 2 > make[2]: Leaving directory `/tmp/buildd/clewn-1.14/runtime' > make[1]: *** [install-recursive] Error 1 > make[1]: Leaving directory `/tmp/buildd/clewn-1.14' > make: *** [install] Error 2 > dpkg-buildpackage: failure: fakeroot debian/rules binary gave error exit > status 2 > --->8--- > > You could simplify your rules file a lot with debhelper 7's nice > shortening features, you have a compat level 7 already but don't use > them. For example, you could use a clewn.manpages file and avoid calling > dh_installman yourself, and rely on dh7 to be intelligent about it. See > [1] for example rules files. Then when build problems occur it's much easier > to see why. > Ok. I will fix this problem and try to simplify the rules file. > Note: once you've fixed these, most sponsors IME prefer to have the same > version number uploaded again to mentors. Good luck finding a sponsor :) > > [1] /usr/share/doc/debhelper/examples/* > > -- > Jonathan Wiltshire > > PGP/GPG: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3 A903 CA6B EA3E DB80 0B52 Thanks for your review. Rémy Dautriche
Attachment:
signature.asc
Description: Digital signature