[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: dict-jargon (updated package)



Hi KiBi!
Thanks for your comments :)

El dom, 18-01-2009 a las 10:04 +0100, Cyril Brulebois escribió:
> Ruben Molina <rmolina@udea.edu.co> (17/01/2009):
> > I am looking for a sponsor for the new version 4.4.7-1 of my package
> > "dict-jargon".
>  - You want to say Build-Depends rather than Depends in the changelog.
Indeed. Thanks!

>  - You are *not* allowed to change past changelog entries. The changelog
Why not? I was unable to find any reference to this on the policy or the
developers reference...

...I agree, cosmetic changes (as indentation, or newlines) aren't
needed, and all of them were reverted (reducing the interdiff output)...

But I think some changes are still needed:

* There are five syntax error lintian warnings: 

  W: dict-jargon: syntax-error-in-debian-changelog line 300 "badly formatted trailer line"
  W: dict-jargon: syntax-error-in-debian-changelog line 254 "found change data where expected next heading or eof"
  W: dict-jargon: syntax-error-in-debian-changelog line 267 "found change data where expected next heading or eof"
  W: dict-jargon: syntax-error-in-debian-changelog line 298 "found change data where expected next heading or eof"
  W: dict-jargon: syntax-error-in-debian-changelog line 304 "found change data where expected next heading or eof"

This causes parsing errors as we can see on bts, for the 1998-1999
changelog entries:
http://packages.debian.org/changelogs/pool/main/d/dict-jargon/current/changelog

All the warnings are from old 'dict-misc' changelog, included for
reference by the previous maintainer.

In the first revision I removed a trailing 'A' on line 300, and
uncommented the headings on lines 252, 265, 296, and 302, to solve the
warnings...

* All the entries after line 318 are duplicated (45% of the file).
Sorry, I didn't mention it on my own changelog...
In the first revision I removed all this lines...

I need some advice before preparing a new revision...

Lines 320-322 says:

  Local variables:
  mode: debian-changelog
  End:

and this seems to stop the changelog parsing, as the duplicates lines
aren't listed on bts, and they aren't reported as warnings by lintian...

So, the less intrusive solution seems to be moving the 'Local
variables:' stuff from lines 320-322 to line 250, where the 'dict-misc'
changelog entries are listed...

...But anyway, I really think all the duplicate entries should be
removed...

questions:

[a] Is the removing of duplicates acceptable?
[b] Are the removing of trailing 'A' and the uncommenting of headings
acceptable?
[c] Is the moving the 'Local variables:' lines acceptable?
(and... Is this breaking of changelog parsing safe?)
[d] Is better to just include an override?

and possible solutions:

* [a+b] (as in first revision)
* [a+c] (close to [a+b], with lesser interdiff)
* [b] (as in first revision, but preserving duplicates)
* [c] (less intrussive, preserves duplicates)
* [d] (no changes are allowed)

I still prefer [a+b], but please recommend the best solution, and I will
prepare a new revision.

BTW, there is a piuparts problem on the package, but it seems to be
inheritanced from dictd (an adduser issue).

Thanks a lot!
Ruben Molina

Attachment: signature.asc
Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente


Reply to: